Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jenkins): Using null breaks the cache mechanism #939

Merged
merged 3 commits into from
May 11, 2021
Merged

fix(jenkins): Using null breaks the cache mechanism #939

merged 3 commits into from
May 11, 2021

Conversation

JHeilCoveo
Copy link
Contributor

Fix issue spinnaker/spinnaker#6217.

Here is what happens now :

  • buildNumber gets casted from null to "null" when calling pendingOperationsCache.setOperationStatus(pendingKey, PendingOperationsCache.OperationStatus.COMPLETED, buildNumber)
  • Next call from orca evaluate !Strings.isNullOrEmpty(pendingStatus.value) as true and returns "null" as job identifier thus breaking the next step.

@dreynaud dreynaud self-requested a review May 11, 2021 17:24
@dreynaud dreynaud added the ready to merge Approved and ready for merge label May 11, 2021
dreynaud
dreynaud approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@dreynaud dreynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mergify mergify bot merged commit f61b499 into spinnaker:master May 11, 2021
@mergify mergify bot added the auto merged label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreynaud dreynaud dreynaud approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.27
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JHeilCoveo @dreynaud @spinnakerbot