Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Increase get5_demo_upload_url max length #1034

Open
2 tasks done
FlowingSPDG opened this issue Aug 1, 2023 · 3 comments
Open
2 tasks done

[Feature Request]: Increase get5_demo_upload_url max length #1034

FlowingSPDG opened this issue Aug 1, 2023 · 3 comments

Comments

@FlowingSPDG
Copy link

Prereleases & Documentation

Get5 Version

v0.15.0

The Feature

Currently I am building cloud based management system that manages srcds and get5 matches.
I am planning to upload demo through Google Cloud Run or something, but it has body length limit(32MiB) for HTTP/1.
So I am going to let srcds upload demo cloud storage directly, but url length would be about 900 chars.
is it possible to increase them?

Thank you for developing and maintaining great plugin for CSGO community!

@FlowingSPDG
Copy link
Author

Here's match schema for get5_loadmatch_url .
https://got5-match-loader-op4haeqloa-an.a.run.app/get5/match/329523134

@nickdnk
Copy link
Collaborator

nickdnk commented Aug 1, 2023

As far as I can tell it's just a matter of increasing this constant: https://github.com/splewis/get5/blob/development/scripting/get5/util.sp#L6

I think going to 1025 would probably be fine. I can change this later today for 0.15.1.

@FlowingSPDG
Copy link
Author

I made PR for it, let me know if we need additional modification!
#1035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants