fix: remove-pytest_exception_interact hook

[kdoroszko-splunk]

This PR reverts partially changes introduced in this PR:
7cc8880#diff-2699a131e5dfd55b20327a39ec213c806ee847e17b6666faf0a01fe850448f47L558
This change is necessary, since exiting pytest while getting Exception disturbed other tests (fr example UI test https://splunk.atlassian.net/browse/ADDON-72764). Instead of that HEC token is validated by ingesting simple event with it (implemented in this PR: #877).

[pawel-dabro]

I'm trying to understand how this worked before, my impression is that just specifying an invalid token in the fixture was enough to fail some tests and then the assertion checked that this in fact happened. And I'm not clear on why now we need to poke the endpoint with a fake message to trigger the error. If we didn't do that before - where was the exception that satisfied the previous assertion coming from?

[harshilgajera-crest]

Hey @kdoroszko-splunk , can you help me understand, how earlier it was breaking UI tests. Maybe we can get on a call if requried.

[kdoroszko-splunk]

Hey @kdoroszko-splunk , can you help me understand, how earlier it was breaking UI tests. Maybe we can get on a call if requried.

Hello @harshilgajera-crest,
It was breaking UI tests because of this parts of the code: https://github.com/splunk/pytest-splunk-addon/pull/881/files#diff-bd63a95fdfaf908e52f87842a005bcb019d56cc3bcb9cf491952b9402c0affef.
There was an Exception appearing while some element on webpage was not found (example comes from MSCS TA):
!!!!!!!!!!!!! _pytest.outcomes Exit: Exiting pytest due to: «ExceptionInfo Exception('Timeout: Message: by=css selector select=[data-test="control-group"][data-name="http_timeout"] input Element not found in the page\n') tblen=19> !!!!!!!!!!!!!
which caused pytest exit after ~10 tests (the whole testset contains ~120 test cases)

So the root cause was that previous solution was to general.

• At first I had this approach: fix: splunk hec token exception handling #872 to create specific exception for HEC token validation, but this solution required communication between pytest nodes, which was not ideal
• So I decided to go with another approach - to validate hec token after checking Splunk instance connection (implemented here: fix: add Splunk HEC token validation for external Splunk #877)

[srv-rr-github-token]

🎉 This issue has been resolved in version 5.4.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀