Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #18 - Feature to configure autoscaler block and attributes for spotinst-ocean-eks #19

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

bharatgovindaradjou
Copy link
Contributor

Currently ocean-eks module defaults autoscaler configuration to automatic configuration when enabled. The autoscaler is also enabled by default.

autoscaler {
    autoscale_is_enabled     = true
    autoscale_is_auto_config = true
  }
}

The purpose of this issue is to add some flexibility to spotinst/ocean-eks module to make use of the ability to configure autoscaler available in the spotinst_ocean_aws resource.

This gives us infrastructure designers and engineers using spotinst to develop ocean clusters configurable for autoscalers' headroom, cooldown and resource limits and even pass on values to ocean's virtual node groups

autoscaler {
  autoscale_is_enabled     = true
  autoscale_is_auto_config = true
  auto_headroom_percentage = 100
  autoscale_cooldown       = 300

  autoscale_headroom {
    cpu_per_unit    = 1024
    gpu_per_unit    = 0
    memory_per_unit = 512
    num_of_units    = 2
  }

  autoscale_down {
    max_scale_down_percentage = 60
  }

  resource_limits {
    max_vcpu       = 1024
    max_memory_gib = 1500
  }
}

The following vars have been introduced that can be added to ocean-eks module to achieve this

enable_autoscaler
auto_headroom_percentage
autoscaler_cooldown
autoscaler_cpu_per_unit
autoscaler_gpu_per_unit
autoscaler_memory_per_unit
autoscaler_num_of_units
autoscaler_max_scale_down_percentage
autoscaler_max_vcpu
autoscaler_max_memory_gib

…eks module (#1)

Co-authored-by: Bharat Kumar Govindaradjou <bgovindaradjou@ip-192-168-0-7.eu-west-1.compute.internal>
@liranp
Copy link
Contributor

liranp commented Oct 12, 2021

@bharatgovindaradjou I apologize for the delay in reviewing this. Your work is greatly appreciated. Can you please rebase your branch and resolve any existing conflicts before we merge it with master? Thanks.

@bharatgovindaradjou
Copy link
Contributor Author

@liranp Thank you for the review. I have rebased from spotinst master and resolved the conflicts. Please merge at your convenience.

@bharatgovindaradjou
Copy link
Contributor Author

@liranp Please confirm the release in which this will be included.

@liranp liranp merged commit 96ec4e2 into spotinst:master Nov 2, 2021
liranp pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Bharat Kumar Govindaradjou <bgovindaradjou@ip-192-168-0-7.eu-west-1.compute.internal>
liranp pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Bharat Kumar Govindaradjou <bgovindaradjou@ip-192-168-0-7.eu-west-1.compute.internal>
liranp pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Bharat Kumar Govindaradjou <bgovindaradjou@ip-192-168-0-7.eu-west-1.compute.internal>
liranp pushed a commit that referenced this pull request Nov 2, 2021
Co-authored-by: Bharat Kumar Govindaradjou <bgovindaradjou@ip-192-168-0-7.eu-west-1.compute.internal>
@liranp
Copy link
Contributor

liranp commented Nov 2, 2021

Thank you for your contribution, @bharatgovindaradjou. Release v1.7.0 is available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants