fix: ignore changes on desired_capacity #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capacity of an Ocean cluster is meant to vary over time (since Ocean acts as a cluster autoscaler). For this reason, if a user re-applies their Terraform script, the cluster should not revert back to the desired_capacity set in the Terraform script. This would disrupt the workloads of the user. This behavior is taken from the ocean-aws-k8s module: https://github.com/spotinst/terraform-spotinst-ocean-aws-k8s/blob/main/ocean.tf#L109
stevenfeltner
approved these changes
Jul 13, 2022
stevenfeltner
approved these changes
Jul 13, 2022
stevenfeltner
approved these changes
Jul 18, 2022
Lironrad
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capacity of an Ocean cluster is meant to vary over time (since
Ocean acts as a cluster autoscaler).
For this reason, if a user re-applies their Terraform script, the
cluster should not revert back to the desired_capacity set in the
Terraform script. This would disrupt the workloads of the user.
This behavior is taken from the ocean-aws-k8s module:
https://github.com/spotinst/terraform-spotinst-ocean-aws-k8s/blob/main/ocean.tf#L109