Implement ServiceInstance.getMetadata

[spencergibb]

New from spring-cloud/spring-cloud-commons#56

[tkvangorder]

Until this enhancement has been completed, what is the recommended way to get access to the meta-data? We are using Eureka so we don't have to have a generalized solution, we just need access to the meta-data.

[spencergibb]

@tkvangorder this is for spring-cloud-zookeeper. spring-cloud-netflix already implements this.

[tkvangorder]

Sorry, I should look closer at the issue details, I was reviewing spring-cloud/spring-cloud-netflix#419 but I missed the commit. spring-cloud/spring-cloud-netflix@03f6d12

I'm not using the latest version yet, so I will just cast the service Instances into Eureka instances until we upgrade. (not pretty, but only temporary) Thanks for the help.

[orevial]

@spencergibb what is the point of implementing ServiceInstance.getMetadata() here ? It seems to me that it is not really used except in discovery client, but when registering instances to Zookeeper the ServiceInstance class used is the one from Curator... shouldn't we consider a way to register a ServiceInstance with a custom payload instead ? Being able to customize the payload would be cool, i.e. not giving ServiceInstance<ZookeeperInstance> but ServiceInstance<ZookeeperInstanceInterface>or such ?!

Or am I missing something here ?