Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect thread usage in SynchronizedItemStreamReaderTests #837

Closed
spring-projects-issues opened this issue Oct 30, 2018 · 0 comments
Closed

Incorrect thread usage in SynchronizedItemStreamReaderTests #837

spring-projects-issues opened this issue Oct 30, 2018 · 0 comments
Labels
in: infrastructure related-to: multi-threading type: bug
Milestone
5.1.0-M1

Comments

@spring-projects-issues
Copy link
Collaborator

Dimitrios Liapis opened BATCH-2767 and commented

While working on the PR for BATCH-2752 I found out that SynchronizedItemStreamReaderTests and SynchronizedItemStreamReaderBuilderTests have the following issue: 

The test threads are not properly started but rather their run method gets invoked

 I've addressed this issue and also performed some refactoring.

Few points about the approach followed:

  • using an atomic integer to track access to the read method
  • using a CountDownLatch to get all the threads ready
  • using assertion within the read method (closely paired with the atomic integer above)

Referenced from: pull request #666
@fmbenhassine fmbenhassine added in: infrastructure and removed status: waiting-for-triage Issues that we did not analyse yet labels May 15, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone May 15, 2020
@fmbenhassine fmbenhassine removed this from the 4.3.0 milestone Sep 21, 2020
@fmbenhassine fmbenhassine added this to the 5.1.0 milestone Jun 12, 2023
@fmbenhassine fmbenhassine changed the title Fixing and Refactoring SynchronizedItemStreamReaderTests [BATCH-2767] Fixing and Refactoring SynchronizedItemStreamReaderTests Jun 12, 2023
@fmbenhassine fmbenhassine changed the title Fixing and Refactoring SynchronizedItemStreamReaderTests Incorrect thread usage in SynchronizedItemStreamReaderTests Jun 12, 2023
@fmbenhassine fmbenhassine modified the milestones: 5.1.0, 5.1.0-M1 Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: infrastructure related-to: multi-threading type: bug
Projects
None yet
Milestone
5.1.0-M1
Development

No branches or pull requests
2 participants
@fmbenhassine @spring-projects-issues