Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document unsupported configuration properties in Freemarker WebFlux #11199

Closed
bclozel opened this issue Nov 29, 2017 · 3 comments
Closed

Document unsupported configuration properties in Freemarker WebFlux #11199

bclozel opened this issue Nov 29, 2017 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Nov 29, 2017

As explained in #10094 (comment), some of the keys in the spring.freemarker.* namespace aren't supported in WebFlux.

We should properly document limitations and enhance the existing support if possible.

@bclozel bclozel self-assigned this Nov 29, 2017
@hantsy
Copy link

hantsy commented Dec 3, 2017

@bclozel It seems spring-boot-starter-freemarker still depends on a spring-boot-starter-web directly, it is possible make it optional?

When I started a WebFlux application(based on Spring Boot 2.0.0.M7), I have to exclude spring-boot-starter-web explicitly.

See: https://github.com/hantsy/spring-reactive-sample/blob/master/boot-freemarker/pom.xml#L39-L44

I have updated my sample, the auto configuration for webflux works well now.

@wilkinsona
Copy link
Member

@hantsy Please open a separate issue for that. It seems like a sensible change to me (it would align with what was done for Thymeleaf) but is not related to configuration properties.

@snicoll
Copy link
Member

snicoll commented Aug 2, 2024

Looking at those properties, most of them are available only to a "template" view resolver

  • spring.freemarker.allow-request-override
  • spring.freemarker.allow-session-override
  • spring.freemarker.expose-request-attributes
  • spring.freemarker.expose-session-attributes
  • spring.freemarker.expose-spring-macro-helpers
  • spring.freemarker.content-type

We could override the metadata with "Not supported on WebFlux" or something like that.

As for caching spring.freemarker.cache is still not supported.

@snicoll snicoll assigned snicoll and unassigned bclozel Aug 2, 2024
@snicoll snicoll changed the title Check unsupported configuration properties in Freemarker WebFlux Document unsupported configuration properties in Freemarker WebFlux Aug 2, 2024
@snicoll snicoll added type: documentation A documentation update and removed type: enhancement A general enhancement labels Aug 2, 2024
@snicoll snicoll closed this as completed in efaebb1 Aug 2, 2024
@snicoll snicoll modified the milestones: 3.x, 3.4.0-M2 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants