Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate SNAPSHOT updates in integration tests #16453

Closed
bclozel opened this issue Apr 4, 2019 · 0 comments
Closed

Reinstate SNAPSHOT updates in integration tests #16453

bclozel opened this issue Apr 4, 2019 · 0 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Apr 4, 2019

In fa4a3ab, we removed forced SNAPSHOT updates as an attempt to solve #12689.

In recent builds, and after incompatible changes made in Framework and Boot for #16427, we got several failed builds like:

***************************
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration.requestMappingHandlerAdapter(WebMvcAutoConfiguration.java:494)

The following method did not exist:

    org.springframework.web.servlet.config.annotation.DelegatingWebMvcConfiguration.requestMappingHandlerAdapter(Lorg/springframework/web/accept/ContentNegotiationManager;Lorg/springframework/format/support/FormattingConversionService;Lorg/springframework/validation/Validator;)Lorg/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter;

The method's class, org.springframework.web.servlet.config.annotation.DelegatingWebMvcConfiguration, is available from the following locations:

    jar:file:/tmp/build/14ea0570/git-repo/spring-boot-tests/spring-boot-integration-tests/spring-boot-devtools-tests/target/dependencies/spring-webmvc-5.2.0.BUILD-SNAPSHOT.jar!/org/springframework/web/servlet/config/annotation/DelegatingWebMvcConfiguration.class

It was loaded from the following location:

    file:/tmp/build/14ea0570/git-repo/spring-boot-tests/spring-boot-integration-tests/spring-boot-devtools-tests/target/dependencies/spring-webmvc-5.2.0.BUILD-SNAPSHOT.jar

This points to an incompatible method signature between Framework and Boot, but this is not consistent with the previous steps of the build since other modules were OK. This pointed to a stale SNAPSHOT in the build-integration-tests task.

This issue is about reinstating the SNAPSHOT updates in that task to avoid future issues like this.

@bclozel bclozel added the type: task A general task label Apr 4, 2019
@bclozel bclozel added this to the 2.2.0.M2 milestone Apr 4, 2019
@bclozel bclozel self-assigned this Apr 4, 2019
@bclozel bclozel closed this as completed in 81d3945 Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant