-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24568
Comments
Thanks for the suggestion. paging @garyrussell as |
It is, indeed, a |
I will take a look to my first issue :) |
Alright @martindacos, the issue is yours and please let us know if you have any questions. |
Hi @snicoll, the PR is ready for review. Let me know if I have to change something. |
Closing in favor of #24582. |
Hi, this is a
first-timers-only
issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
If you have contributed before, consider leaving this one for someone new, and looking through our general
ideal-for-contribution
issues. Thanks!Problem
When configuring a Kafka listener, it is possible to suppress the entire record from being written to the log when retries are being attempted.
This feature is not supported by the auto-configuration.
Solution
A new
onlyLogRecordMetadata
property should be added to KafkaProperties#Listener with the relevant description of the property on the field's javadoc.Once the property is exposed, it should be mapped by the auto-configuration.
This happens in ConcurrentKafkaListenerContainerFactoryConfigurer#configureContainer
Finally, the existing tests in
KafkaAutoConfigurationTests
should be updated to execises the newspring.kafka.listener.only-log-record-metadata
property (seelistenerProperties
).Steps to Fix
The text was updated successfully, but these errors were encountered: