Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot uses an internal jetty class #33833

Closed
Sineaggi opened this issue Jan 14, 2023 · 5 comments
Closed

Spring Boot uses an internal jetty class #33833

Sineaggi opened this issue Jan 14, 2023 · 5 comments
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@Sineaggi
Copy link

Spring Boot is using an internal jetty class here in the JettyWebSocketServletWebServerCustomizer.java:23

This means if you were planning on running your dependencies (jackson, slf4j, logback and jetty) on the module path and keep spring-boot on the unnamed-module you'd need to add the flag
--add-opens org.eclipse.jetty.websocket.jakarta.server/org.eclipse.jetty.websocket.jakarta.server.internal=ALL-UNNAMED

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 14, 2023
@wilkinsona
Copy link
Member

This is intentional. We try to minimise our use of internal API but will use it where there's no alternative. This may improve with Jetty 12 which we intend to support in Spring Boot 3.1 if the release dates line up.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 16, 2023
@Sineaggi Sineaggi changed the title Sprint Boot uses an internal jetty class Spring Boot uses an internal jetty class Jan 17, 2023
@wilkinsona
Copy link
Member

Re-opening as there's now some new public API that we should see if we can use as part of upgrading to Jetty 12.

@wilkinsona wilkinsona reopened this Feb 20, 2023
@wilkinsona wilkinsona added type: task A general task and removed status: declined A suggestion or change that we don't feel we should currently apply labels Feb 20, 2023
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.x Feb 20, 2023
@rafaelrc7
Copy link
Contributor

Hello, I would like to try solving this issue. By reading what was discussed here and in jetty/jetty.project#9182 it seems that there are two possible solutions: Either calling the same methods that were made public or following the Jetty's team's suggestion, which one would be preferable?

@wilkinsona
Copy link
Member

Thanks for the offer, @rafaelrc7, but we can't upgrade to Jetty 12 just yet. I have some work in progress in this branch but it's currently blocked by jetty/jetty.project#9173.

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label May 18, 2023
@wilkinsona
Copy link
Member

This was addressed in #36073.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
@wilkinsona wilkinsona removed this from the 3.x milestone May 31, 2024
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: blocked An issue that's blocked on an external project change labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants