-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring Boot uses an internal jetty class #33833
Comments
This is intentional. We try to minimise our use of internal API but will use it where there's no alternative. This may improve with Jetty 12 which we intend to support in Spring Boot 3.1 if the release dates line up. |
Re-opening as there's now some new public API that we should see if we can use as part of upgrading to Jetty 12. |
Hello, I would like to try solving this issue. By reading what was discussed here and in jetty/jetty.project#9182 it seems that there are two possible solutions: Either calling the same methods that were made public or following the Jetty's team's suggestion, which one would be preferable? |
Thanks for the offer, @rafaelrc7, but we can't upgrade to Jetty 12 just yet. I have some work in progress in this branch but it's currently blocked by jetty/jetty.project#9173. |
This was addressed in #36073. |
Spring Boot is using an internal jetty class here in the JettyWebSocketServletWebServerCustomizer.java:23
This means if you were planning on running your dependencies (jackson, slf4j, logback and jetty) on the module path and keep spring-boot on the unnamed-module you'd need to add the flag
--add-opens org.eclipse.jetty.websocket.jakarta.server/org.eclipse.jetty.websocket.jakarta.server.internal=ALL-UNNAMED
The text was updated successfully, but these errors were encountered: