Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the minimum supported version of Gradle 8 to 8.4 #42481

Closed
wilkinsona opened this issue Sep 30, 2024 · 0 comments
Closed

Raise the minimum supported version of Gradle 8 to 8.4 #42481

wilkinsona opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Sep 30, 2024

Upgrading to Jackson 2.18 (#42480) reveals an incompatibility with Gradle 8.3:

Caused by: java.io.IOException: Failed to process the entry 'META-INF/versions/22/com/fasterxml/jackson/core/internal/shaded/fdp/v2_18_0/FastDoubleSwar.class' from '/Users/awilkinson/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-core/2.18.0/65e8ead7de5d8f7a53e296c363bea3182f21f925/jackson-core-2.18.0.jar'
	at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$visitEntries$1(InstrumentingClasspathFileTransformer.java:222)
	at org.gradle.internal.classpath.ClasspathWalker.visitJarContents(ClasspathWalker.java:91)
	at org.gradle.internal.classpath.ClasspathWalker.visit(ClasspathWalker.java:55)
	at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.visitEntries(InstrumentingClasspathFileTransformer.java:201)
	at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$instrument$0(InstrumentingClasspathFileTransformer.java:192)
	at org.gradle.internal.classpath.ClasspathBuilder.buildJar(ClasspathBuilder.java:68)
	at org.gradle.internal.classpath.ClasspathBuilder.jar(ClasspathBuilder.java:55)
	... 9 more
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 66
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:199)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
	at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$visitEntries$1(InstrumentingClasspathFileTransformer.java:207)
	... 15 more

We can work around this with some complex build setup that downgrades Jackson to 2.17 when using Gradle 8.3. Alternatively, we can avoid that by raising the minimum supported version of Gradle to 8.4. Gradle 8.4 was released in October 2023 so it will have been available for over a year by the time Boot 3.4 GAs so I think we should raise the minimum supported Gradle version.

@wilkinsona wilkinsona added this to the 3.4.x milestone Sep 30, 2024
@wilkinsona wilkinsona self-assigned this Sep 30, 2024
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Sep 30, 2024
@wilkinsona wilkinsona modified the milestones: 3.4.x, 3.4.0-RC1 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant