-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24582
Conversation
Very nice @martindacos. Thank you for making your first contribution to Spring Boot. |
Happy to help @snicoll ! It's fine the way that I did to create the PR and the branch? I was reading the contributing guide but I didn't found any example, can you point me to the documentation for the future? Thanks |
Usually you'd create first a branch from your clone (rather than doing the changes directly on I think the contributing page describes the things that are Spring Boot specific. If you believe differently, feel free to create an issue or another PR. |
Alright, thank you |
@snicoll Please note that the default is now true in 2.7.0-SNAPSHOT: spring-projects/spring-kafka@62046c2 |
Thank you Gary, I was subscribed to this issue. We have a test to check the consistency of the default that'll fail once we switch. |
Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24568