Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24582

Closed
wants to merge 1 commit into from

Conversation

martindacos
Copy link
Contributor

Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24568

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 21, 2020
@mbhave mbhave added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 21, 2020
@mbhave mbhave added this to the 2.5.x milestone Dec 21, 2020
@snicoll snicoll changed the title Add configuration option to configure Kafka Listener's onlyLogRecordMetadata #24568 Add configuration option to configure Kafka Listener's onlyLogRecordMetadata Dec 22, 2020
@snicoll snicoll self-assigned this Dec 22, 2020
@snicoll snicoll modified the milestones: 2.5.x, 2.5.0-M1 Dec 22, 2020
@snicoll snicoll closed this in 72a22f8 Dec 22, 2020
@snicoll
Copy link
Member

snicoll commented Dec 22, 2020

Very nice @martindacos. Thank you for making your first contribution to Spring Boot.

@martindacos
Copy link
Contributor Author

Happy to help @snicoll ! It's fine the way that I did to create the PR and the branch? I was reading the contributing guide but I didn't found any example, can you point me to the documentation for the future?

Thanks

@snicoll
Copy link
Member

snicoll commented Dec 22, 2020

Usually you'd create first a branch from your clone (rather than doing the changes directly on master) which is a general recommendation when submitting a PR, nothing Spring Boot specific. Other than that, it was very good yes. I did polish the contribution because the property has a default value in Spring Kafka and I wanted to make sure it is advertized properly in the metadata.

I think the contributing page describes the things that are Spring Boot specific. If you believe differently, feel free to create an issue or another PR.

@martindacos
Copy link
Contributor Author

Alright, thank you

@garyrussell
Copy link
Contributor

@snicoll Please note that the default is now true in 2.7.0-SNAPSHOT: spring-projects/spring-kafka@62046c2

@snicoll
Copy link
Member

snicoll commented Dec 22, 2020

Thank you Gary, I was subscribed to this issue. We have a test to check the consistency of the default that'll fail once we switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants