Add SslBundle support to MailSender #40037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
ruifigueira
force-pushed
the
feature/mail-sender-sslbundle
branch
from
026b409 to
e9b7527
Compare
scottfrederick
added
type: enhancement
scottfrederick
changed the title
ruifigueira
force-pushed
the
feature/mail-sender-sslbundle
branch
5 times, most recently
from
3b22b8e to
fdb86de
Compare
|
I added some integration tests using a Mailpit testcontainer, both in TLS/SSL mode and using |
ruifigueira
force-pushed
the
feature/mail-sender-sslbundle
branch
from
f11116c to
6d88fa0
Compare
ruifigueira
force-pushed
the
feature/mail-sender-sslbundle
branch
from
6d88fa0 to
ff5525e
Compare
Validate both SSL/TLS and STARTTLS modes with SSL bundles against a Mailpit testcontainer
ruifigueira
force-pushed
the
feature/mail-sender-sslbundle
branch
from
ff5525e to
7c72130
Compare
mhalbritter
pushed a commit
that referenced
this pull request
Jul 4, 2024
mhalbritter
added a commit
that referenced
this pull request
Jul 4, 2024
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MailPropertiesdoesn't support SslBundle configuration. There are scenarios where a client has a SMTP server with a certificate signed by a local CA and we don't have a simple way to configure MailSender to use a different SSL context, andSslBundlesseems to be a great fit here.This PR adds support to SSL configuration using a SslBundle.