Add support for Pulsar default tenant/namespace #41851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows Pulsar users to configure a default tenant and/or namespace to be used when producing or consuming messages to topic URLs that are not fully-qualified. The following changes accomplish this: - add `tenant` and `namespace` config props to `spring.pulsar.defaults` - auto-configure a `PulsarTopicBuilder` bean populated w/ above props - provide above topic builder to producer/consumer/reader factories (imperative and reactive) - add tests for all of the above
spring-projects-issues
added
the
status: waiting-for-triage
The builder is stateful and as such each injection point needs its own bean instance.
wilkinsona
reviewed
Aug 15, 2024
Comment on lines
253
to
266
| /** | ||
| * Default tenant to use when producing or consuming messages against a | ||
| * non-fully-qualified topic URL. When not specified Pulsar uses a default tenant | ||
| * of 'public'. | ||
| */ | ||
| private String tenant; | ||
|
|
||
| /** | ||
| * Default namespace to use when producing or consuming messages against a | ||
| * non-fully-qualified topic URL. When not specified Pulsar uses a default | ||
| * namespace of 'default'. | ||
| */ | ||
| private String namespace; | ||
|
|
There was a problem hiding this comment.
As these properties both relate to topics, it would be good to put them both in a topic group so they'd become spring.pulsar.defaults.topic.tenant and spring.pulsar.defaults.topic.namespace. I think that still makes sense given that typeMappings is partially topic related. What do you think though, @cbono?
There was a problem hiding this comment.
Great suggestion as this also gives way to adding an enabled flag to the spring.pulsar.defaults.topic to disable default topics if so desired.
...nfigure/src/main/java/org/springframework/boot/autoconfigure/pulsar/PulsarConfiguration.java
Show resolved
Hide resolved
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Aug 20, 2024
This commit allows Pulsar users to configure a default tenant and/or namespace to be used when producing or consuming messages to topic URLs that are not fully-qualified. See gh-41851
wilkinsona
added a commit
that referenced
this pull request
Aug 20, 2024
wilkinsona
added a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows Pulsar users to configure a default tenant and/or namespace to be used when producing or consuming messages to topic URLs that are not fully-qualified.
The following changes accomplish this:
tenantandnamespaceconfig props tospring.pulsar.defaultsPulsarTopicBuilderbean populated w/ above props