Make OtlpMeterRegistry virtual thread aware #42407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mturbe
changed the title
mturbe
changed the title
mhalbritter
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Hello @mturbe, thanks for the PR. I've added a comment for your consideration.
.../java/org/springframework/boot/actuate/autoconfigure/metrics/export/otlp/OtlpProperties.java
Outdated
Show resolved
Hide resolved
mhalbritter
added
the
status: waiting-for-feedback
mhalbritter
requested changes
Sep 25, 2024
.../boot/actuate/autoconfigure/metrics/export/otlp/OtlpMetricsExportAutoConfigurationTests.java
Show resolved
Hide resolved
...c/main/java/org/springframework/boot/testsupport/assertj/ScheduledExecutorServiceAssert.java
Outdated
Show resolved
Hide resolved
mhalbritter
changed the title
mhalbritter
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Sep 26, 2024
mhalbritter
added a commit
that referenced
this pull request
Sep 26, 2024
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for virtual threads in OtlpMeterRegistry configuration per issue #42175.