Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide service connection support for Hazelcast #42416

Closed
wants to merge 1 commit into from
Closed

Provide service connection support for Hazelcast #42416

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Sep 22, 2024

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 22, 2024
@nosan nosan force-pushed the 34778 branch 2 times, most recently from cfb416c to 1430fb3 Compare September 22, 2024 18:12
@philwebb philwebb mentioned this pull request Sep 23, 2024
Closed
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 23, 2024
@philwebb philwebb added this to the 3.4.x milestone Sep 23, 2024
@nosan
Copy link
Contributor Author

nosan commented Sep 23, 2024 •
edited
Loading

The open question is about hazelcast/hazelcast-enterprise image, should I add it as well?

https://hub.docker.com/r/hazelcast/hazelcast-enterprise

You do not need to set a license key for your Java clients for which you want to use Hazelcast IMDG Enterprise features. Hazelcast IMDG Enterprise license keys are required only for members.

mhalbritter
mhalbritter reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@mhalbritter mhalbritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nosan, thanks for the PR! I've left some comments for your consideration.

...ker/compose/service/connection/hazelcast/HazelcastDockerComposeConnectionDetailsFactory.java Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-docker-compose/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved
...-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/dev-services.adoc Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-testcontainers/build.gradle Outdated Show resolved Hide resolved
spring-boot-project/spring-boot-testcontainers/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved
...t-support-docker/src/main/java/org/springframework/boot/testsupport/container/TestImage.java Outdated Show resolved Hide resolved
@mhalbritter
Copy link
Contributor

mhalbritter commented Sep 25, 2024 •
edited
Loading

The open question is about hazelcast/hazelcast-enterprise image, should I add it as well?

https://hub.docker.com/r/hazelcast/hazelcast-enterprise

I can't start hazelcast/hazelcast-enterprise without setting an enterprise key.

com.hazelcast.license.exception.InvalidLicenseException: The Hazelcast Enterprise license key is not set.
To set the license key, please do one of the following:
  - Change member config using Java API: config.setLicenseKey("...")
  - Change XML/YAML configuration property: Set hazelcast.license-key: ...
  - Add system property: -Dhz.licensekey=... (for Hazelcast embedded, works only when loading config via Config.load)
  - Add environment variable: HZ_LICENSEKEY=... (recommended when running container image. For Hazelcast embedded, works only when loading config via Config.load)

You do not need to set a license key for your Java clients for which you want to use Hazelcast IMDG Enterprise features. Hazelcast IMDG Enterprise license keys are required only for members.

I think I don't understand this sentence. Does that mean I don't have to set the license key on the client which connects to the enterprise server?

@nosan
Copy link
Contributor Author

nosan commented Sep 25, 2024 •
edited
Loading

I think I don't understand this sentence. Does that mean I don't have to set the license key on the client which connects to the enterprise server?

Yes, you are right. You don't need to configure a client with a license key to connect to hazelcast-enterprise.

I can't start hazelcast/hazelcast-enterprise without setting an enterprise key.

I verified this locally (I have a license key).

I am asking because I understand that adding this image without a test does not sound right.
I can add this image and test for it but in that case, HZ_LICENSEKEY should be configured on Spring Boot CI.

JUnit condition (EnabledIfEnvironmentVariable) as well.

@mhalbritter mhalbritter added the for: team-meeting An issue we'd like to discuss as a team to make progress label Sep 25, 2024
@mhalbritter
Copy link
Contributor

Thanks for the clarification. I'll talk to the team about this.

@wilkinsona
Copy link
Member

I don't think we should add support for hazelcast-enterprise as we can't (easily) test it.

@nosan
Copy link
Contributor Author

nosan commented Sep 25, 2024

Thank you very much for your review @mhalbritter
I fixed your comments. I hope I did not mess with sorting.

@mhalbritter mhalbritter self-assigned this Sep 26, 2024
mhalbritter pushed a commit that referenced this pull request Sep 26, 2024
@nosan @mhalbritter
Add service connection support for Hazelcast
cee7439 
See gh-42416
mhalbritter added a commit that referenced this pull request Sep 26, 2024
@mhalbritter
Polish "Add service connection support for Hazelcast"
33def6d 
See gh-42416
@mhalbritter
Copy link
Contributor

Thanks @nosan !

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-RC1 Sep 26, 2024
@nosan nosan deleted the 34778 branch September 26, 2024 15:19
@nosan
Copy link
Contributor Author

nosan commented Sep 26, 2024

Thank you @mhalbritter

@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhalbritter mhalbritter mhalbritter left review comments

Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-RC1
Development

Successfully merging this pull request may close these issues.
5 participants
@nosan @mhalbritter @wilkinsona @philwebb @spring-projects-issues