Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HttpWebServiceMessageSenderBuilder javadoc #42868

Closed
wants to merge 1 commit into from
Closed

Update HttpWebServiceMessageSenderBuilder javadoc #42868

wants to merge 1 commit into from

Conversation

wickdynex
Copy link
Contributor

Description

This PR try to update the javadoc from file HttpWebServiceMessageSenderBuilder.java. In this file's javadoc, it's methods says can @return a new builder instance, but actually @return the current builder instance. Therefore, I fixed the doc bug.

Related Issue

Fixes #42858

Additional Notes

If there's anything else I can help with, plz comment.

@wickdynex
Update HttpWebServiceMessageSenderBuilder javadoc
af3f199 
Update the return javadoc from "@return a new builder instance" to "@return the current builder instance".
@pivotal-cla
Copy link

@1328032567 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 24, 2024
@pivotal-cla
Copy link

@1328032567 Thank you for signing the Contributor License Agreement!

@wickdynex wickdynex mentioned this pull request Oct 24, 2024
Closed
@wilkinsona
Copy link
Member

Thanks for the pull request, but #42858 is already assigned to someone which indicates that they're already working on it. As such, I'm afraid that we won't accept a pull request.

@wilkinsona wilkinsona closed this Oct 24, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2024
@wickdynex
Copy link
Contributor Author

Thanks for the pull request, but #42858 is already assigned to someone which indicates that they're already working on it. As such, I'm afraid that we won't accept a pull request.

What a pity! Btw, I'm also new in open-source, it's my attempt to make contributions on spring-boot project. Anyway, thanks for your reply.

@philwebb philwebb reopened this Oct 26, 2024
@philwebb philwebb self-assigned this Oct 26, 2024
@philwebb philwebb added type: documentation A documentation update and removed status: declined A suggestion or change that we don't feel we should currently apply labels Oct 26, 2024
@philwebb philwebb added this to the 3.2.x milestone Oct 26, 2024
@philwebb philwebb mentioned this pull request Oct 26, 2024
Closed
philwebb pushed a commit that referenced this pull request Oct 26, 2024
@wickdynex @philwebb
Update HttpWebServiceMessageSenderBuilder javadoc
1730bf6 
Update the return javadoc from "@return a new builder instance" to
"@return the current builder instance".

See gh-42868
@philwebb philwebb closed this in dc32cb8 Oct 26, 2024
@philwebb philwebb modified the milestones: 3.2.x, 3.2.12 Oct 26, 2024
@philwebb
Copy link
Member

Thanks @1328032567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.2.12
Development

Successfully merging this pull request may close these issues.
5 participants
@wickdynex @pivotal-cla @wilkinsona @philwebb @spring-projects-issues