Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-info doesn't support seconds since the epoch from project.build.outputTimestamp #42922

Closed
wants to merge 3 commits into from

Conversation

ahoehma
Copy link
Contributor

@ahoehma ahoehma commented Oct 29, 2024

Use MavenBuildOutputTimestamp inside BuildInfoMojo to create Instant from project.build.outputTimestamp where the value of this property is in just epoch seconds.

#42871

Use MavenBuildOutputTimestamp inside BuildInfoMojo to create Instant
from project.build.outputTimestamp where the value of this property is
in just epoch seconds.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 29, 2024
@wilkinsona wilkinsona changed the title fix(maven): buildinfo doesn't support seconds since the epoch build-info doesn't support seconds since the epoch from project.build.outputTimestamp Oct 29, 2024
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 29, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Oct 29, 2024
@snicoll snicoll self-assigned this Oct 30, 2024
@snicoll snicoll modified the milestones: 3.2.x, 3.2.12 Oct 30, 2024
snicoll pushed a commit that referenced this pull request Oct 30, 2024
This commit completes the support of project.build.outputTimestamp to
also support a value that's expressed as seconds since the epoch.

See gh-42922
@snicoll snicoll closed this in bb29625 Oct 30, 2024
@snicoll
Copy link
Member

snicoll commented Oct 30, 2024

@ahoehma thanks and congrats for making you first contribution to Spring Boot.

@ahoehma ahoehma deleted the issue-42871 branch November 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants