Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timeout property for GraphQL over SSE #42966

Closed
wants to merge 1 commit into from
Closed

Support timeout property for GraphQL over SSE #42966

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Nov 1, 2024

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 1, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 1, 2024
@philwebb philwebb added this to the 3.4.x milestone Nov 1, 2024
@philwebb
Copy link
Member

philwebb commented Nov 1, 2024

Might try and squeeze this into 3.4 since it's low risk

@philwebb philwebb mentioned this pull request Nov 1, 2024
Closed
@nosan
Copy link
Contributor Author

nosan commented Nov 1, 2024 •
edited
Loading

@philwebb
I haven’t set a default timeout, as I don't know what would be an appropriate default value.

@rstoyanchev
Could you please suggest a suitable default value?

@philwebb philwebb self-assigned this Nov 1, 2024
philwebb pushed a commit that referenced this pull request Nov 1, 2024
@nosan @philwebb
Support timeout property for GraphQL over SSE
85b1c56 
See gh-42966
@philwebb philwebb closed this in c2ab2dd Nov 1, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.4.0 Nov 1, 2024
@philwebb philwebb reopened this Nov 1, 2024
@philwebb
Copy link
Member

philwebb commented Nov 1, 2024

Reopening because I missed the comment about a default timeout

@philwebb
Copy link
Member

philwebb commented Nov 1, 2024

Actually, I think null is the best option for the default timeout.

@philwebb philwebb closed this Nov 1, 2024
@bclozel bclozel mentioned this pull request Nov 9, 2024
Closed
@Netyyyy Netyyyy mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nosan @philwebb @spring-projects-issues