Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-data-envers pulls in various javax and JBoss spec jars when their jakarta.* equivalents are preferred #331

Open
wilkinsona opened this issue Nov 12, 2021 · 3 comments
Assignees
Labels
for: team-attention An issue we need to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged

Comments

@wilkinsona
Copy link
Member

We had an initiative a few years ago across the Spring portfolio to consistently use jakarta.* spec jars. spring-data-envers has got out of step with this, pulling in the following:

  • javax.activation:javax.activation-api
  • javax.persistence:javax.persistence-api
  • javax.xml.bind:jaxb-api
  • org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec

Could these please be excluded and their Jakarta equivalents depended upon instead?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2021
@mp911de mp911de added the for: team-attention An issue we need to discuss as a team to make progress label Nov 16, 2021
@dmitry-weirdo
Copy link

dmitry-weirdo commented Nov 14, 2022

I guess it's related to the upcoming Spring / Spring Boot 3.0 release that will use Hibernate 6.1.5+ (see https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0-RC2). And there is still no 3.0.0 RC for spring-hibernate-envers (at least I don't set it here on https://github.com/spring-projects/spring-data-envers/releases). hibernate-envers:6.1.5.Final exists, see https://mvnrepository.com/artifact/org.hibernate.orm/hibernate-envers/6.1.5.Final.

@schauder
Copy link
Contributor

@wilkinsona
Copy link
Member Author

I guess it's related to the upcoming Spring / Spring Boot 3.0 release

This request isn't related to Spring Boot 3.0, in fact I think the upgrade to Jakarta EE 9/10 has taken care of things already. This issue applies to Jakarta EE 8 where there are both JBoss spec jars and official spec jars and consistent use of the official spec jars would help to avoid duplicate classes on people's classpaths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: team-attention An issue we need to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

5 participants