Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for package binding in the JibxMashaller [SPR-7805] #12461

Closed
spring-projects-issues opened this issue Dec 3, 2010 · 2 comments
Closed
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 3, 2010

Tiago Stürmer Daitx opened SPR-7805 and commented

As per https://jira.springframework.org/browse/SWS-229 JibxMashaller already supports all the mapped classes in the IBindingFactory (wonder why the docs don't say anything about that) but I needed a way to set it per package so I have created my own JibxMarshaller and have been using it successfully so far.

By default it will ignore targetPackage property if targetClass property is set to keep the usual behavior.

I have also updated it to fix https://jira.springsource.org/browse/SWS-659 as stated on the forum because I had a similar scenario where I needed multiple marshallers (one per root element). Since changing this method will break anyone who has been using the "set class and get binding for all mapped classes" feature/bug I'm adding two patches: one with all the changes and another with everything but the supports(Class) method change.

BTW, I generated the patch against JibxMarshaller from Spring 3.0.5. Let me know if I really need to do it against SWS 1.5.9.


Affects: 3.0.5

Attachments:

Issue Links:

Referenced from: commits fa4f90e

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

No need to create a SWS version of this patch, as SWS's OXM has been removed completely in favor of SPR's OXM.

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

I've applied the -with-supports patch. This can result in some issues with regards to backward compatibility, but as the patch provides a clear improvement over the current code, I'm OK with doing this for Spring 3.1.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants