Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BEST_MATCHING_PATTERN_ATTRIBUTE with RequestMappingHandlerMapping [SPR-8712] #13354

Closed
spring-projects-issues opened this issue Sep 20, 2011 · 2 comments
Closed

Expose BEST_MATCHING_PATTERN_ATTRIBUTE with RequestMappingHandlerMapping [SPR-8712] #13354

spring-projects-issues opened this issue Sep 20, 2011 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
3.1 RC1

Comments

@spring-projects-issues
Copy link
Collaborator

John Cook opened SPR-8712 and commented

Please, expose the best matching pattern (HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE) with Spring 3.1+ RequestMappingHandlerMapping as it used to be with Spring 3.0 DefaultAnnotationHandlerMapping (resp. in AbstractUrlHandlerMapping.exposePathWithinMapping).
Though it is still possible to expose it by myself with a specialized HandlerInterceptor, I don't see any reason, why it shouldn't be exposed directly from framework.

Affects: 3.1 M2

Referenced from: commits f200ccd
@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Indeed, no reason not to expose this attribute.

@spring-projects-issues
Copy link
Collaborator Author

John Cook commented

Wow, that was pretty fast! Thanks :)

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.1 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
3.1 RC1
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues