Refactor AnnotationUtils#findAllAnnotationAttributes to accommodate non-default class loader [SPR-8752]

[spring-projects-issues]

Ittay Dror opened SPR-8752 and commented

Line 347:
MetadataReader reader = new SimpleMetadataReaderFactory().getMetadataReader(annotatedClassName);

This creates a MetadataReader that uses the default class loader. But the class name may be from a different class loader. This causes a failure later on when trying to load the class name

---

Affects: 3.1 M2

Referenced from: commits 6837111

[spring-projects-issues]

Chris Beams commented

Thanks, Ittay.

commit 1bbc643c812438111e7b6716acfaa3b6150796c2
Author: Chris Beams <cbeams@vmware.com>
Date:   Sun Oct 9 20:32:21 2011 +0000

    Refactor AnnotationUtils#findAllAnnotationAttributes
    
    Remove all convenience variants of #findAllAnnotationAttributes and
    refactor the remaining method to accept a MetadataReaderFactory
    instead of creating its own SimpleMetadataReaderFactory internally.
    This allows clients to use non-default class loaders as well as
    customize the particular MetadataReaderFactory to be used (e.g.
    'simple' vs 'caching', etc).
    
    Issue: SPR-8752