Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraalVM workaround in PathMatchingResourcePatternResolver #29214

Closed
sbrannen opened this issue Sep 28, 2022 · 0 comments
Closed

Remove GraalVM workaround in PathMatchingResourcePatternResolver #29214

sbrannen opened this issue Sep 28, 2022 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing
Milestone

Comments

@sbrannen
Copy link
Member

This is a follow up to #29163.

Once oracle/graal#5080 and oracle/graal#5081 have been resolved (tentatively in GraalVM 22.3), we should be able to remove the following workaround in PathMatchingResourcePatternResolver.

// If the URI is for a "resource" in the GraalVM native image file system, we have to
// ensure that the root directory does not end in a slash while simultaneously ensuring
// that the root directory is not an empty string (since fileSystem.getPath("").resolve(str)
// throws an ArrayIndexOutOfBoundsException in a native image).
if ("resource".equals(rootDirUri.getScheme()) && (rootDir.length() > 1) && rootDir.endsWith("/")) {
rootDir = rootDir.substring(0, rootDir.length() - 1);
}

@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing labels Sep 28, 2022
@sbrannen sbrannen added this to the 6.0.0-RC2 milestone Sep 28, 2022
@sbrannen sbrannen self-assigned this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing
Projects
None yet
Development

No branches or pull requests

1 participant