Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize Reactor client class names within the http.client package #33382

Closed
jhoeller opened this issue Aug 13, 2024 · 2 comments
Closed

Harmonize Reactor client class names within the http.client package #33382

jhoeller opened this issue Aug 13, 2024 · 2 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.2.0-RC1

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Aug 13, 2024 •
edited
Loading

The recent introduction of ReactorNettyClientRequestFactory brought a naming inconsistency with ReactorClientHttpConnector as well as HttpComponentsClientHttpRequestFactory: it would rather have to be called ReactorClientHttpRequestFactory. However, there is also ReactorNetty2ClientHttpConnector, so ReactorClientHttpConnector could also be named ReactorNettyClientHttpConnector instead. To wrap it up, HttpComponentsClientHttpRequestFactory could be named HttpComponentsClientRequestFactory (dropping the repeated Http from the interface name, just like in ReactorNettyClientRequestFactory).
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Aug 13, 2024
@jhoeller jhoeller added this to the 6.2.0-RC1 milestone Aug 13, 2024
Torres-09 added a commit to Torres-09/spring-framework that referenced this issue Aug 20, 2024
@Torres-09
Refine naming consistency for HttpRequestFactories
3d6e78b 
This commit renames three classes to improve naming consistency within the Spring Framework:
- `ReactorNettyClientRequestFactory` -> `ReactorClientHttpRequestFactory`
- `ReactorClientHttpConnector` -> `ReactorNettyClientHttpConnector`
- `HttpComponentsClientHttpRequestFactory` -> `HttpComponentsClientRequestFactory`

These changes align the class names with others in the project, reducing redundancy and improving clarity. This update affects 31 files.

Issue: spring-projects#33382
Torres-09 added a commit to Torres-09/spring-framework that referenced this issue Aug 20, 2024
@Torres-09
Refine naming consistency in RestOperations interface
421d1ba 
- Updated references from `HttpComponentsClientHttpRequestFactory` to `HttpComponentsClientRequestFactory`.

Issue: spring-projects#33382
@Torres-09 Torres-09 mentioned this issue Aug 20, 2024
Closed
@rstoyanchev
Copy link
Contributor

@jhoeller, see #33411 proposal to address this issue.

@jhoeller jhoeller self-assigned this Sep 10, 2024
@jhoeller
Copy link
Contributor Author

I am going with the simplest possible renaming: just ReactorNettyClientRequestFactory to ReactorClientHttpRequestFactory, leaving all other class names as they are. This achieves local consistency within the http.client` package which is the most important part.

@jhoeller jhoeller changed the title Harmonize Reactor Netty client class names Harmonize Reactor client class names within the http.client package Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC1
Development

No branches or pull requests
2 participants
@rstoyanchev @jhoeller