Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractGenericHttpMessageConverter has no constructor taking a Charset #33563

Closed
OrangeDog opened this issue Sep 18, 2024 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@OrangeDog
Copy link

AbstractHttpMessageConverter has a constructor (Charset defaultCharset, MediaType... supportedMediaTypes).

AbstractGenericHttpMessageConverter extends it, but provides no access to that constructor.

That forces implementors to call setDefaultCharset in their constructors, which gives a this-escape warning since Java 18 unless they are declared final.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 18, 2024
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Sep 20, 2024
@sdeleuze sdeleuze self-assigned this Sep 24, 2024
@sdeleuze sdeleuze added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 24, 2024
@sdeleuze sdeleuze added this to the 6.2.0-RC2 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants