-
Notifications
You must be signed in to change notification settings - Fork 38.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DynamicPropertyRegistrarBeanInitializer
public
#33593
Comments
Thanks for raising the issue, @wilkinsona.
I apologize: I somehow missed that comment.
That would of course be great if Spring Boot can benefit from the new
In Spring Framework, we don't have any support for "dynamic properties" other than in the However, I think it should be fine to make Shall I go ahead and make that change this week so that you can try it out with 6.2 snapshots? |
Yes please, Sam. Support that's only available in |
DynamicPropertyRegistrarBeanInitializer
public
Feel free to try it out in upcoming 6.2 snapshots. |
I've updated the prototype and it looks good to me. Thanks! |
Great! Glad to hear that. |
Overview
Affects: 6.2
Following up on this comment, we have prototyped a change to Spring Boot that is a step towards replacing its support for injecting a
DynamicPropertyRegistry
with support forDynamicPropertyRegistrar
beans instead.As explained in the comment in #33501, additional support for
DynamicPropertyRegistrar
is needed for dynamic property registration when using Testcontainers at development time. In tests, it isn't needed as the test context framework already enables the support through its context customizer.The prototype of the changes to Boot currently uses reflection when defining a
DynamicPropertyRegistrarBeanInitializer
bean as the initializer is package-private. This has helped to verify the approach but isn't something that we'd want to ship.Can Framework 6.2 please provide an SPI for enabling
DynamicPropertyRegistrar
support outside of the test context framework, or perhaps just makeDynamicPropertyRegistrarBeanInitializer
public so that we don't need to use reflection?Related Issues
DynamicPropertyRegistrar
as a replacement forDynamicPropertyRegistry
bean support #33501The text was updated successfully, but these errors were encountered: