Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultServerHttpRequestBuilder can create case-sensitive Headers instances #33666

Closed
simonbasle opened this issue Oct 8, 2024 · 0 comments
Closed

DefaultServerHttpRequestBuilder can create case-sensitive Headers instances #33666

simonbasle opened this issue Oct 8, 2024 · 0 comments
Assignees
@simonbasle
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
6.2.0-RC2

Comments

@simonbasle
Copy link
Contributor

In 6.2.0-M5, the DefaultServerHttpRequestBuilder was modified to ensure copying read-only headers would result in a mutable HttpHeaders instance. Unfortunately, the way this is implemented has a side effect: the case-insensitive nature of the headers is lost.

See https://github.com/spring-projects/spring-framework/pull/32097/files#r1791264218
@simonbasle simonbasle added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Oct 8, 2024
@simonbasle simonbasle added this to the 6.2.0-RC2 milestone Oct 8, 2024
@simonbasle simonbasle self-assigned this Oct 8, 2024
@simonbasle simonbasle mentioned this issue Oct 8, 2024
Closed
@encircled encircled mentioned this issue Oct 9, 2024
Closed
@spencergibb spencergibb mentioned this issue Oct 11, 2024
Closed
spencergibb added a commit to spring-cloud/spring-cloud-gateway that referenced this issue Oct 11, 2024
@spencergibb
Reverts workaround for case-insensitive headers.
cf5171b 
Fixed by spring-projects/spring-framework#33666
@spencergibb spencergibb mentioned this issue Oct 16, 2024
Closed
@bclozel bclozel mentioned this issue Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
6.2.0-RC2
1 participant
@simonbasle