Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise handling of URI variable syntax in WhatWG URL parser #33673

Closed
rstoyanchev opened this issue Oct 9, 2024 · 0 comments
Closed

Revise handling of URI variable syntax in WhatWG URL parser #33673

rstoyanchev opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Oct 9, 2024

The new WhatWG URL parser enters a special URI_TEMPLATE state on open {, and remains there until }, effectively suspending checks for general delimiters at URI component boundaries. This is in contrast to the regular expressions used before, which did not do handle curly braces specially, except in the port, but otherwise parsed along general delimiters.

We should revise how the new parser handles URI variable syntax to match closer what we did before, prioritizing safer parsing and better aligning with how user agents might parse the same, in line with the goals for the parser.

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Oct 9, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0-RC2 milestone Oct 9, 2024
@rstoyanchev rstoyanchev self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant