Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower-casing of scheme in UriComponentsBuilder breaks use of URI variables #33699

Closed
rstoyanchev opened this issue Oct 14, 2024 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@rstoyanchev
Copy link
Contributor

Spring Security started seeing test failures after #33639 due to the scheme now being lower-cased. The OAuth2 redirect_uri in is parsed from {baseScheme}://... and on 6.2.0-SNAPSHOT, the scheme becomes {basescheme}, which does not match the template variable name. We need to revise the parsers to allow use of URI variables in the scheme.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels Oct 14, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0-RC2 milestone Oct 14, 2024
@rstoyanchev rstoyanchev self-assigned this Oct 14, 2024
quaff added a commit to quaff/spring-framework that referenced this issue Oct 16, 2024
quaff added a commit to quaff/spring-framework that referenced this issue Oct 16, 2024
…RI variable

See spring-projectsGH-33699, Continue c261ca3

```
Map has no value for 'thescheme'
java.lang.IllegalArgumentException: Map has no value for 'thescheme'
	at org.springframework.web.util.UriComponents$MapTemplateVariables.getValue(UriComponents.java:348)
	at org.springframework.web.util.UriComponents.expandUriComponent(UriComponents.java:263)
	at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:436)
	at org.springframework.web.util.HierarchicalUriComponents.expandInternal(HierarchicalUriComponents.java:53)
	at org.springframework.web.util.UriComponents.expand(UriComponents.java:161)
	at org.springframework.web.util.UriComponentsBuilder.buildAndExpand(UriComponentsBuilder.java:364)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant