Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explanation of AOP advice classes that should implement MethodInterceptor #33901

Closed
bdshadow opened this issue Nov 16, 2024 · 1 comment
Closed

Improve explanation of AOP advice classes that should implement MethodInterceptor #33901

bdshadow opened this issue Nov 16, 2024 · 1 comment
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Milestone
6.2.1

Comments

@bdshadow
Copy link
Contributor

The following page: https://docs.spring.io/spring-framework/reference/core/aop-api/advice.html has a weird sentence:

Classes that implement MethodInterceptor and that implement around advice should also implement the following interface: MethodInterceptor

Shorter, it says: "Classes that implement MethodInterceptor should implement MethodInterceptor". If I'm not missing anything, this sentence is confusing. If I do miss something, I think it must be explained a little more explicitly.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 16, 2024
@sbrannen sbrannen self-assigned this Nov 17, 2024
@sbrannen sbrannen added type: documentation A documentation task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 17, 2024
@sbrannen sbrannen added this to the 6.2.1 milestone Nov 17, 2024
@sbrannen sbrannen changed the title docs: confusing explanation of classes, that should implement MethodInterceptor Improve explanation of AOP advice classes that should implement MethodInterceptor Nov 17, 2024
@sbrannen
Copy link
Member

Good catch! 👍

This has been revised in 241b8b4 (see also: 173084f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Milestone
6.2.1
Development

No branches or pull requests
3 participants
@sbrannen @bdshadow @spring-projects-issues