Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit HttpHeaders implementing the MultiValueMap API #33913

Open
simonbasle opened this issue Nov 19, 2024 · 1 comment
Open

Revisit HttpHeaders implementing the MultiValueMap API #33913

simonbasle opened this issue Nov 19, 2024 · 1 comment
Assignees
@simonbasle
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone
7.0.x

Comments

@simonbasle
Copy link
Contributor

simonbasle commented Nov 19, 2024 •
edited
Loading

See #33823 : the MultiValueMap methods that iterate over the whole header collection misalign with some underlying server implementations.

On the other hand having HttpHeaders implement MultiValueMap brings in some (marginal?) benefits: using CollectionUtils, asserting headers with map-specific assertions, putting all the headers into a plain Map (map.putAll(headers)), etc...
@simonbasle simonbasle added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 19, 2024
@simonbasle simonbasle added this to the 7.0.x milestone Nov 19, 2024
@simonbasle simonbasle self-assigned this Nov 19, 2024
@simonbasle simonbasle changed the title Revisit HttpHeaders implementing the MultiValueMap API Revisit HttpHeaders implementing the MultiValueMap API Nov 19, 2024
@simonbasle simonbasle added the status: pending-design-work Needs design work before any code can be developed label Nov 20, 2024
@bclozel bclozel mentioned this issue Nov 21, 2024
Closed
@simonbasle
Copy link
Contributor Author

Keeping track of notable areas where we check for generic Map for headers (and now should check for both Map and HttpHeaders):

  • RequestHeaderMapMethodArgumentResolver
  • RequestHeaderMethodArgumentResolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.x
Development

No branches or pull requests
1 participant
@simonbasle