Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure removal of Content-Type header if body Publisher is empty #32622

Conversation

NadChel
Copy link
Contributor

@NadChel NadChel commented Apr 11, 2024

I added a removal of Content-Type header in org.springframework.http.codec.EncoderHttpMessageWriter if the body Publisher is empty

Added a couple of tests to assert on the writer's correct behavior when dealing with empty body Publishers

The GH-32620 issue is a blocker for a Spring Cloud Gateway issue I've been researching

@NadChel
Copy link
Contributor Author

NadChel commented Apr 15, 2024

Is there something else I need to do to have it approved and merged?

@sbrannen sbrannen changed the title Ensured removal of Content-Type header if body Publisher is empty. Fixes GH-32620 Ensure removal of Content-Type header if body Publisher is empty Apr 16, 2024
@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Apr 16, 2024
@poutsma poutsma self-assigned this Apr 22, 2024
@poutsma poutsma added this to the 6.2.0-M2 milestone Apr 23, 2024
@poutsma poutsma added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 23, 2024
@poutsma poutsma closed this in 3f8a10c Apr 23, 2024
poutsma added a commit that referenced this pull request Apr 23, 2024
poutsma added a commit that referenced this pull request Apr 23, 2024
…_type_if_no_body

* gh-32622:
  Polishing external contribution
  Remove Content-Type when body is empty
@poutsma
Copy link
Contributor

poutsma commented Apr 24, 2024

Thank you for submitting a PR. This will be in the upcoming 6.2M2 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants