Improve optional parameter checks for HTTP Interface argument #33339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
in: web
snicoll
changed the title
rstoyanchev
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Thanks for the changes.
Overall looks good. One minor suggestion for all the argument resolvers to check for null first and exit early. I think that would make it easier to read. Something like:
if (argument == null) {
Assert.isTrue(parameter.isOptional(), "HttpMethod is required");
return true;
}
// argument is not null...
...g-web/src/main/java/org/springframework/web/service/invoker/RequestBodyArgumentResolver.java
Outdated
Show resolved
Hide resolved
rstoyanchev
changed the title
rstoyanchev
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-31467.