Refactor eTag formatting logic into a static utility method #33412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
the
in: web
|
To be considered when we'll work on #33385 |
rstoyanchev
added
type: enhancement
rstoyanchev
pushed a commit
that referenced
this pull request
Sep 10, 2024
rstoyanchev
added a commit
that referenced
this pull request
Sep 10, 2024
Update checks whether quoting is needed to be more complete than what we've used so far, making sure the there is both opening and closing quotes independent of each other. See gh-33412
rstoyanchev
added a commit
that referenced
this pull request
Sep 10, 2024
This aligns HttpHeaders with other places like ServletWebRequest and DefaultWebExchange where an ETag is accepted as input. It also allows us to remove quoting from places that delegate to HttpHeaders#setETag since it now does that internally. Closes gh-33412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the eTag formatting logic by consolidating it into a static format method within the ETag record class.
The changes aim to eliminate duplicated code and improve maintainability.
Summary of Changes:
formatmethod to theETagrecord class to handle eTag formatting.formatmethod for eTag formatting.Thank you for reviewing this pull request!