Add read timeout setter on HttpComponentsClientHttpRequestFactory #33556
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timeout on the underlying client This brings the HttpComponentsClientHttpRequestFactory into alignment with JDK, Jetty, OkHttp3 and SimpleClient ClientHttpRequestFactory's
|
@cmagnuson Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@cmagnuson Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
simonbasle
added
in: web
|
thanks for the contribution @cmagnuson. Looks good to me, I will polish the javadoc/formatting and add some tests before merging, fixing the checkstyle error along the way |
simonbasle
approved these changes
Sep 18, 2024
simonbasle
pushed a commit
that referenced
this pull request
Sep 18, 2024
This commit adds support for HttpComponentsClientHttpRequestFactory to set a read timeout, used on the underlying client as a RequestTimeout. This brings the HttpComponentsClientHttpRequestFactory into alignment with JDK, Jetty, OkHttp3, Reactor and SimpleClient ClientHttpRequestFactory implementations. See gh-33556
simonbasle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the HttpComponentsClientHttpRequestFactory into alignment with JDK, Jetty, OkHttp3 and SimpleClient ClientHttpRequestFactory's.
The read timeout is a pretty common value to set, so I think it is helpful to allow configuring it directly from the factory, vs. supplying a custom
RequestConfigandHttpClientto the factory.