Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish CorsConfiguration #33650

Closed
wants to merge 1 commit into from
Closed

Polish CorsConfiguration #33650

wants to merge 1 commit into from

Conversation

khyojun
Copy link
Contributor

@khyojun khyojun commented Oct 4, 2024 •
edited
Loading

Changes & Considerations

  • The * symbol was already handled as a constant, but the / symbol was not. Handling this as a constant will improve readability.
  • Additionally, the * symbol was replaced in other parts of the code, but it was not replaced in OriginPattern, which caused some confusion. It seems necessary to replace it there as well.

@khyojun
Refactor : Replace hardcoded PATH_SEPERATOR & ALL mark in ALL_PATERN
0cdc536 
- The * symbol was already handled as a constant, but the / symbol was not. Handling this as a constant will improve readability.
- Additionally, the * symbol was replaced in other parts of the code, but it was not replaced in OriginPattern, which caused some confusion. It seems necessary to replace it there as well.
@pivotal-cla
Copy link

@khyojun Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@khyojun Thank you for signing the Contributor License Agreement!

@khyojun khyojun closed this Oct 4, 2024
@khyojun khyojun reopened this Oct 4, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 4, 2024
@sdeleuze sdeleuze self-assigned this Oct 7, 2024
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 7, 2024
@sdeleuze sdeleuze added this to the 6.2.0-RC2 milestone Oct 7, 2024
@sdeleuze sdeleuze changed the title Refactor : Replace hardcoded PATH_SEPERATOR & ALL mark in ALL_PATERN Polish CorsConfiguration Oct 7, 2024
@sdeleuze sdeleuze closed this in f86bc1c Oct 7, 2024
@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 7, 2024

Thanks for your contribution, I only merged the replacement of "*" by the existing public static field ALL, since the other change does not bring much from my POV. Notice we do not add @author tag for such minor change.

@khyojun
Copy link
Contributor Author

khyojun commented Oct 7, 2024

@sdeleuze "As a student, this is my first time contributing to open source, so I'm a bit unsure! In this case, does this mean I've also contributed to the Spring code? I'm asking because it's my first experience, and I'm so excited!"

@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 7, 2024

Yes, you did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC2
Development

Successfully merging this pull request may close these issues.
4 participants
@khyojun @pivotal-cla @sdeleuze @spring-projects-issues