Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scheduling.adoc #33709

Closed
wants to merge 1 commit into from
Closed

Conversation

boulce
Copy link
Contributor

@boulce boulce commented Oct 15, 2024

Change executor to 'executor' like "The 'scheduler' Element" or "The 'scheduled-tasks' Element" for unity.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 15, 2024
@sdeleuze
Copy link
Contributor

I am not sure that would be consistent, we are still using backticks for task for example. It looks like backticks are more often used and are rendering nicely, with a meaning that we are quoting something from the code which is the case here, so maybe update the PR the other way around consistently for the section of this file?

@sdeleuze sdeleuze self-assigned this Oct 15, 2024
@boulce
Copy link
Contributor Author

boulce commented Oct 15, 2024

I am not sure that would be consistent, we are still using backticks for task for example. It looks like backticks are more often used and are rendering nicely, with a meaning that we are quoting something from the code which is the case here, so maybe update the PR the other way around consistently for the section of this file?

Then Is okay If I change "The 'scheduler' Element" to "The scheduler Element" and "The 'scheduled-tasks' Element" to "The scheduled-tasks Element"?
Therefore, you mean, "The 'scheduler' Element" and "The 'scheduled-tasks' Element" are wrong?

Change quotation marks to backticks.
@boulce
Copy link
Contributor Author

boulce commented Oct 15, 2024

I am not sure that would be consistent, we are still using backticks for task for example. It looks like backticks are more often used and are rendering nicely, with a meaning that we are quoting something from the code which is the case here, so maybe update the PR the other way around consistently for the section of this file?

I changed as you mentioned. Please check.

@sdeleuze sdeleuze added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 15, 2024
@sdeleuze sdeleuze added this to the 6.2.0-RC2 milestone Oct 15, 2024
sdeleuze pushed a commit to sdeleuze/spring-framework that referenced this pull request Oct 15, 2024
Change quotation marks to backticks.

Closes spring-projectsgh-33709
@sdeleuze sdeleuze closed this in 166714c Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants