Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JwtAuthenticationConverter needs a way to merge authorities from UserDetailsService into JwtAuthenticationToken #6243

Closed
edeandrea opened this issue Dec 6, 2018 · 1 comment

Comments

@edeandrea
Copy link
Contributor

edeandrea commented Dec 6, 2018

Currently in JwtAuthenticationConverter the authorities passed into new JwtAuthenticationToken come only from the scopes on the token. If the user has set a UserDetailsService or ReactiveUserDetailsService then the authorities returned from userDetailsService.loadByUsername(subject).getAuthorities() / reactiveUserDetailsService.findByUsername(subject).getAuthorities() should be merged into the authorities in the JwtAuthenticationToken.

@edeandrea
Copy link
Contributor Author

I think what was done in #6273 will solve this as well. It will allow someone to be able to assemble their own JwtGrantedAuthoritiesConverter in whichever way they want.

I'm fine to close this out unless there is more to add. We can re-open at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant