OAuth2ResourceServer configuration tests use deprecated extractAuthorities

[jzheaux]

JwtAuthenticationConverter#extractAuthorities was deprecated in #6273 via 0f7dff3.

OAuth2ResourceServerConfigurerTests and OAuth2ResourceServerSpecTests should be updated to no longer use it, changing instead to use setJwtGrantedAuthoritiesConverter.

[vishalvrv9]

Hey @jzheaux, haven't completely analyzed the issue but would like to work on it. Can I take this up?

[jzheaux]

Yep, it's yours! Feel free to ping me with any questions.

When you are ready to push, check out the contribution guidelines.

[jzheaux]

@vishalvrv9 wanted to check in to see how things are going. Are there any questions I can answer for you?

[vishalvrv9]

Hey @jzheaux ,
firstly, apologies for the delay

As per analysis,

• In OAuth2ResourceServerSpecTests, since the method signature is different from extractAuthorities

what should the implementation changes look like? Can you provide me a starting point as after trying to implement the setJwtGrantedAuthoritiesConverter I am a little lost

[jzheaux]

@vishalvrv9 no problem, my apologies for lagging in my response :)

Something like this might work well:

- JwtAuthenticationConverter converter = new JwtAuthenticationConverter() {
-				@Override
-				protected Collection<GrantedAuthority> extractAuthorities(Jwt jwt) {
-					String[] claims = ((String) jwt.getClaims().get("scope")).split(" ");
-					return Stream.of(claims).map(SimpleGrantedAuthority::new).collect(Collectors.toList());
-				}
-			};
+ JwtAuthenticationConverter converter = new JwtAuthenticationConverter();
+ converter.setJwtGrantedAuthoritiesConverter(jwt -> {
+ 		String[] claims = ((String) jwt.getClaims().get("scope")).split(" ");
+		return Stream.of(claims).map(SimpleGrantedAuthority::new).collect(Collectors.toList());
+ });

[jzheaux]

@vishalvrv9 Is this something that you'd still like to work on?

[vishalvrv9]

Hey @jzheaux, Yeah definitely. Apologies lost track of it. Will try submitting a PR as soon as possible.

[vishalvrv9]

@jzheaux have submitted PR #6904

[jzheaux]

Thanks, @vishalvrv9! I left a bit of feedback in the PR.

[vishalvrv9]

Hey @jzheaux , worked on the feedback a couple of days back.

[jzheaux]

Fixed via b6e8997