Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Resolver Interface #6625

Open
rwinch opened this issue Mar 19, 2019 · 0 comments
Open

Generic Resolver Interface #6625

rwinch opened this issue Mar 19, 2019 · 0 comments
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Mar 19, 2019

Summary

We have quite a few places where we are resolving APIs. OAuth2AuthorizationRequestResolver, SAML is adding a resolver, JWT is adding one.

We should consider create a generic resolver that takes input of HttpServletRequest and a separate one for ServerWebExchange and outputs <T>.

There are also places where we use Function.

There are other places we use Converter.

We need to find consistency throughout the code.

@rwinch rwinch added this to the 5.2.0.M2 milestone Mar 19, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@eleftherias eleftherias modified the milestones: 5.2.0.M3, 5.2.0.RC1 Jun 14, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.M4, 5.2.0.RC1 Aug 5, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.RC1, 5.2.0 Sep 5, 2019
@rwinch rwinch modified the milestones: 5.2.0, 5.3.x Sep 27, 2019
@rwinch rwinch added the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2021
@eleftherias eleftherias added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 3, 2022
@eleftherias eleftherias removed this from the 5.3.x milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants