Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade com.nimbusds:oauth2-oidc-sdk to 7.0.3 #8007

Closed
snicoll opened this issue Feb 21, 2020 · 6 comments
Closed

Upgrade com.nimbusds:oauth2-oidc-sdk to 7.0.3 #8007

snicoll opened this issue Feb 21, 2020 · 6 comments
Assignees
Labels
in: build An issue in the build status: feedback-provided Feedback has been provided
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Feb 21, 2020

oauth2-oidc-sdk has version ranges in the published pom which leads to various issues. This breaks start.spring.io's metadata verification tests so I've reported the problem.

It would be nice if Spring Security would upgrade to this version so that we're not affected by the resolution of version ranges anymore.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2020
@jgrandja
Copy link
Contributor

@snicoll There is a backwards compatibility issue with version 7.0 which I fixed in #7994. I'm not sure if the same issue exists in 7.0.3. Is there a reason you would like us to upgrade to the 7.x line?

@jgrandja jgrandja self-assigned this Feb 21, 2020
@jgrandja jgrandja added in: build An issue in the build status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 21, 2020
@snicoll
Copy link
Member Author

snicoll commented Feb 21, 2020

The fix for the issue I mentioned is only available in the 7.x line as far as I can see.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 21, 2020
@jzheaux jzheaux added this to the 5.3.0 milestone Mar 4, 2020
@chenrujun
Copy link
Contributor

Hi, @jzheaux .
(cc: @snicoll )

You set oauth2-oidc-sdk's version to latest.release in your commit, but in spring-boot-dependencies, the version is 7.1.1, it may cause version conflict problem, such as ClassNotFound / NoSuchMethod.

So can we do like this:

  1. Set version of oauth2-oidc-sdk to 7.1.1, same to the version in spring-boot-dependencies.
  2. Add all all spring-security external dependencies' version to spring-boot-dependencies, and use spring-boot-dependencies to manage external dependencies' version for spring-security?

@chenrujun
Copy link
Contributor

Hi, @snicoll

I see you updated the nimbus-jose-jwt's version to 9.0.1.

Could you please use spring-boot-dependencies for spring-security instead of manage by dependency-management.gradle ?

So we can have uniformed version for spring apps.

@jzheaux
Copy link
Contributor

jzheaux commented Sep 30, 2020

@chenrujun thanks for reaching out and spending some time thinking about this.

Since Boot always releases after Security, it would be tricky to base Security's dependency versions on the ones that Boot is using. That said, I agree that it's important that the two products work well together. Note that Spring Security builds with Boot-based samples to verify compatibility.

As for your own project, any dependencies Spring Boot manages take precedence in your Spring Boot application, so you should be able to look to spring-boot-dependencies for a definitive answer.

That said, note that Spring Security 5.4.0 released with oauth2-oidc-sdk:8.19.1 and nimbus-jose-jwt:9.0. As you noted, Spring Boot 2.4.0-M3 is already using these same minor versions.

Nimbus is a bit of a special case since they release with each PR merge and don't have a stated support policy for major or minor versions. This is why Spring Security uses latest.release to ensure it's able to get Nimbus's security patches and bug fixes.

@chenrujun
Copy link
Contributor

@jzheaux .

I got it. Thank you very much for your detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build status: feedback-provided Feedback has been provided
Projects
None yet
Development

No branches or pull requests

5 participants