Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Framework Tests from saml2Login Sample #8989

Closed
jzheaux opened this issue Aug 28, 2020 · 0 comments
Closed

Remove Framework Tests from saml2Login Sample #8989

jzheaux opened this issue Aug 28, 2020 · 0 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 28, 2020

Most of the tests in the saml2Login sample are related to testing the framework.

Since the purpose of the sample is to demonstrate how Spring Security's SAML 2.0 support works, we can safely remove these tests and simplify the sample overall. We already have tests in the spring-security-saml2-service-provider and spring-security-config modules that test the framework.

@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Aug 28, 2020
@jzheaux jzheaux added this to the 5.4.0 milestone Aug 28, 2020
@jzheaux jzheaux self-assigned this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant