Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-atomic updates to LeaseAwareVaultPropertySource cause leave property source empty until SecretLeaseCreatedEvent #594

Closed
domingogomez-asto opened this issue Nov 5, 2020 · 1 comment
Closed

Non-atomic updates to LeaseAwareVaultPropertySource cause leave property source empty until SecretLeaseCreatedEvent #594

domingogomez-asto opened this issue Nov 5, 2020 · 1 comment
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
2.3 RC1

Comments

@domingogomez-asto
Copy link

As discussed in spring-cloud/spring-cloud-vault#446 there is a small gap of time between SecretLeaseExpiredEvent and SecretLeaseCreatedEvent that makes read of properties at that exact moment to throw IllegalArgumentException.
@domingogomez-asto domingogomez-asto mentioned this issue Nov 5, 2020
Closed
@mp911de mp911de added this to the 2.2.3 milestone Nov 5, 2020
@mp911de mp911de added the type: bug A general bug label Nov 5, 2020
@mp911de mp911de changed the title Some times properties are not readable (IllegalArgumentException) during lease renewal Non-atomic updates to LeaseAwareVaultPropertySource cause leave property source empty until SecretLeaseCreatedEvent Nov 5, 2020
@mp911de mp911de self-assigned this Dec 1, 2020
@mp911de mp911de closed this as completed in ff57fe7 Dec 2, 2020
@mp911de mp911de modified the milestones: 2.2.3, 2.3 RC1 Dec 2, 2020
@mp911de
Copy link
Member

mp911de commented Dec 2, 2020

That's fixed for version 2.3 RC1 now. We'd like to get feedback on this issue before backporting it to the 2.2.x line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
2.3 RC1
Development

No branches or pull requests
2 participants
@mp911de @domingogomez-asto