Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leases no longer revoked after stopping SecretLeaseContainer #855

Closed
NoureddineDahmen opened this issue Jan 31, 2024 · 3 comments
Closed

Leases no longer revoked after stopping SecretLeaseContainer #855

NoureddineDahmen opened this issue Jan 31, 2024 · 3 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@NoureddineDahmen
Copy link

I reopen this issue related to #844
We tested the version 3.1.1 and and unfortunately we still have the issue.

Best regards,
@mp911de
Copy link
Member

mp911de commented Jan 31, 2024

Can you check your shutdown debug logs regarding Vault communication and debug what happens for you in SecretLeaseContainer.destroy() as there is the code path to revoke secrets?

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Jan 31, 2024
@NoureddineDahmen
Copy link
Author

Hello @mp911de , I'm sorry for the delay to give feedback .
In Debug , the method SecretLeaseContainer.destroy() is not called when we use ConfigData and it well called when we use Boostrap Config.

Best Regards,

@NoureddineDahmen NoureddineDahmen mentioned this issue Apr 5, 2024
Closed
@mp911de mp911de added for: external-project For an external project and not something we can fix and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 8, 2024
@mp911de mp911de mentioned this issue Apr 8, 2024
Closed
@mp911de
Copy link
Member

mp911de commented Apr 8, 2024

This needs to be handled in Spring Cloud Vault as part of the bean registration, see spring-cloud/spring-cloud-vault#725

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mp911de @NoureddineDahmen