ActionPropertyAccessor compatibility issue with Spring Framework 6.2
#1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if a Spring Expression Language (SpEL) expression did not include parentheses for a MultiAction method that does not accept a RequestContext argument, the flow would pass on Spring Framework versions prior to 6.2, but the same flow would fail on Spring Framework 6.2 M1 or later. The following is such an expression and is effectively a property reference which must be handled by a registered PropertyAccessor: "reportActions.evaluateReport". The reason for the change in behavior is that Spring Framework 6.2 M1 includes a bug fix for ordering SpEL PropertyAccessors. That bug fix correctly results in Spring Web Flow's ActionPropertyAccessor being evaluated before SpEL's ReflectivePropertyAccessor. Consequently, an expression such as "reportActions.evaluateReport" is now handled by ActionPropertyAccessor which indirectly requires that the action method accept a RequestContext argument. When the method does not accept a RequestContext argument, the flow fails with a NoSuchMethodException. To address that, this commit revises the implementation of canRead(...) in ActionPropertyAccessor so that it only returns `true` if the action method accepts a RequestContext argument. When ActionPropertyAccessor's canRead(...) method returns `false`, the generic ReflectivePropertyAccessor will be used instead, which restores the pre-6.2 behavior for such expressions. The test suite passes for the following Spring Framework versions. - ./gradlew -PspringFrameworkVersion=6.0.23 --rerun-tasks clean check - ./gradlew -PspringFrameworkVersion=6.1.14 --rerun-tasks clean check - ./gradlew -PspringFrameworkVersion=6.2.0-RC3 --rerun-tasks clean check See spring-projects/spring-framework#33861 See spring-projects/spring-framework#33862 Closes spring-projectsgh-1802
rstoyanchev
changed the title
ActionPropertyAccessor on Spring Framework 6.2ActionPropertyAccessor works as before on Spring Framework 6.2
rstoyanchev
changed the title
ActionPropertyAccessor works as before on Spring Framework 6.2ActionPropertyAccessor compatibility issue with Spring Framework 6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prior to this PR, if a Spring Expression Language (SpEL) expression did not include parentheses for a
MultiActionmethod that does not accept aRequestContextargument, the flow would pass on Spring Framework versions prior to 6.2, but the same flow would fail on Spring Framework 6.2 M1 or later. The following is such an expression and is effectively a property reference which must be handled by a registeredPropertyAccessor:reportActions.evaluateReport.The reason for the change in behavior is that Spring Framework 6.2 M1 includes a bug fix for ordering SpEL
PropertyAccessors. That bug fix correctly results in Spring Web Flow'sActionPropertyAccessorbeing evaluated before SpEL'sReflectivePropertyAccessor. Consequently, an expression such asreportActions.evaluateReportis now handled byActionPropertyAccessorwhich indirectly requires that the action method accept aRequestContextargument. When the method does not accept aRequestContextargument, the flow fails with aNoSuchMethodException.To address that, this PR revises the implementation of
canRead(...)inActionPropertyAccessorso that it only returnstrueif the action method accepts aRequestContextargument. WhenActionPropertyAccessor'scanRead(...)method returnsfalse, the genericReflectivePropertyAccessorwill be used instead, which restores the pre-6.2 behavior for such expressions.The test suite passes for the following Spring Framework versions.
./gradlew -PspringFrameworkVersion=6.0.23 --rerun-tasks clean check./gradlew -PspringFrameworkVersion=6.1.14 --rerun-tasks clean check./gradlew -PspringFrameworkVersion=6.2.0-RC3 --rerun-tasks clean checkRelated Issues
PropertyAccessorordering for supertype and generic matches does not adhere to contract spring-framework#33861PropertyAccessorandIndexAccessorAPIs regarding ordering spring-framework#33862