-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Editor migration missing TODOs (Editor) #22005
Merged
ccordoba12
merged 16 commits into
spyder-ide:master
from
dalthviz:editor_migration_todos
May 11, 2024
Merged
PR: Editor migration missing TODOs (Editor) #22005
ccordoba12
merged 16 commits into
spyder-ide:master
from
dalthviz:editor_migration_todos
May 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd teardown logic
dalthviz
changed the title
[WIP] PR: Add doctrings to public/API methods (Editor)
[WIP] PR: Editor migration missing TODOs (Editor)
Apr 23, 2024
dalthviz
force-pushed
the
editor_migration_todos
branch
2 times, most recently
from
May 6, 2024 21:44
e8a7c37
to
8ff1d87
Compare
dalthviz
force-pushed
the
editor_migration_todos
branch
from
May 8, 2024 21:46
24e6315
to
c7f91e8
Compare
dalthviz
changed the title
[WIP] PR: Editor migration missing TODOs (Editor)
PR: Editor migration missing TODOs (Editor)
May 9, 2024
ccordoba12
reviewed
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for your work on this!
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @dalthviz!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
TODOs follow up for #21353
Fixes #17468
TODO
load
methods (load_edit_goto
andload_edit
)on_<>_available
/on_<>_teardown
(Completions plugin)sig_editor_rcp
signal removalAffirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz