Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spyder has to wait 18 seconds before closing #8751

Closed
impact27 opened this issue Feb 11, 2019 · 5 comments
Closed

Spyder has to wait 18 seconds before closing #8751

impact27 opened this issue Feb 11, 2019 · 5 comments

Comments

@impact27
Copy link
Contributor

On the following line:

background(self.shellwidget.kernel_client.stop_channels)

Spyder creates a thread that will close all the channels of kernel_client.
unfortunately, kernel_client has a heartbeat channel that only wakes up every 18 seconds. (kernel_client.hb_channel)
This means that the created thread will have to wait until a heartbeat is heard.

somehow if I replace this line by self.shellwidget.kernel_client.shutdown() spyder closes immediately.

@impact27
Copy link
Contributor Author

I created a pull request on Jupiter client: jupyter/jupyter_client#420

@ccordoba12 ccordoba12 added this to the important milestone Feb 11, 2019
@ccordoba12
Copy link
Member

Ok, thanks a lot for your help @impact27!

@impact27
Copy link
Contributor Author

As a workaround, how bad would it be to not call stop_channels?

@ccordoba12
Copy link
Member

ccordoba12 commented Feb 11, 2019

I don't know and I wouldn't like to speculate about it because I don't know the Jupyter architecture that well.

@ccordoba12 ccordoba12 removed this from the important milestone Feb 15, 2019
@ccordoba12
Copy link
Member

Closing because @impact27's PR was merged in jupyter-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants