From fb9da115b94a254dee8abbfe81601ad3492a996c Mon Sep 17 00:00:00 2001 From: Matt Gerega Date: Mon, 16 Oct 2023 17:02:04 -0400 Subject: [PATCH 1/3] Fixed github action warnings and a code smell --- .github/workflows/node.yml | 4 ++-- src/backend/GoogleTaskService.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index 2f6338d..39bdeec 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -32,7 +32,7 @@ jobs: path: MagicMirror/modules/MMM-GoogleTasks - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} @@ -55,4 +55,4 @@ jobs: projectBaseDir: MagicMirror/modules/MMM-GoogleTasks env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/src/backend/GoogleTaskService.ts b/src/backend/GoogleTaskService.ts index 10397d0..d5a82c7 100644 --- a/src/backend/GoogleTaskService.ts +++ b/src/backend/GoogleTaskService.ts @@ -78,7 +78,7 @@ export class GoogleTaskService { if (accountConfig.includedLists.length === 0) { return true; } - return accountConfig.includedLists.some((list) => list.match(listName)); + return accountConfig.includedLists.some((list) => listName.match(list)); } setTaskServiceWithCredentials(token: Token): void { From 6f5e315b44d15bd78488db233a0e33ed9cb3c21e Mon Sep 17 00:00:00 2001 From: Matt Gerega Date: Tue, 17 Oct 2023 11:52:36 -0400 Subject: [PATCH 2/3] Modified styling for date --- src/frontend/Display.scss | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/frontend/Display.scss b/src/frontend/Display.scss index a6fd087..420e925 100644 --- a/src/frontend/Display.scss +++ b/src/frontend/Display.scss @@ -16,22 +16,20 @@ margin: 0em .5em; text-align: center; color: white; + font-size: 1.0em; border-radius: 25px; } .overdue { background-color: red; - color: white; } .soon { - background-color: orange; - color: black; + background-color: #ad4107; } .upcoming { background-color: green; - color: white; } .notes { From e8fc5c15553a7c32fc5b050034badb149b3b9377 Mon Sep 17 00:00:00 2001 From: Matt Gerega Date: Tue, 17 Oct 2023 12:01:30 -0400 Subject: [PATCH 3/3] Added shields to readme --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 2d2919c..a4439f1 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,9 @@ # MMM-GoogleTasks +![GitHub Workflow Status (with event)](https://img.shields.io/github/actions/workflow/status/spyder007/MMM-GoogleTasks/node.yml) +![Sonar Coverage](https://img.shields.io/sonar/coverage/spyder007_MMM-GoogleTasks/main?server=https%3A%2F%2Fsonarcloud.io) +![Sonar Violations (long format)](https://img.shields.io/sonar/violations/spyder007_MMM-GoogleTasks/main?server=https%3A%2F%2Fsonarcloud.io&label=sonar%20violations) + Module for the [MagicMirror²](https://github.com/MichMich/MagicMirror/) smart mirror. Displays tasks from Google Tasks App